Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tools/time): updating references of time functions #13093

Merged
merged 6 commits into from
May 29, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented May 28, 2024

Summary

We are refactoring kong.tools.*, and trying to updating all references of kong.tools.time, which will make our code more clear and easy to maintain.

KAG-3145

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/balancer cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 28, 2024
@chronolaw chronolaw marked this pull request as ready for review May 28, 2024 06:23
@ADD-SP ADD-SP merged commit 331f01e into master May 29, 2024
25 checks passed
@ADD-SP ADD-SP deleted the refactor/updating_time_tools_references branch May 29, 2024 01:59
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 29, 2024
@chronolaw
Copy link
Contributor Author

Cherry-pick manually after #12952's cherry-pick is merged.

@chronolaw chronolaw added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 29, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 4, 2024
@Kong Kong deleted a comment from team-gateway-bot Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/balancer size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants