dynamic_hook: cumulative changes #13085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
samugi
reviewed
May 27, 2024
samugi
approved these changes
May 27, 2024
samugi
reviewed
May 27, 2024
We haven't used this feature until now, so I removed them to simplify the code logic.
ADD-SP
force-pushed
the
add_sp/fix-dynamic-hook
branch
from
c939e87 to
08602ff
Compare
samugi
reviewed
May 27, 2024
…tion` from `child_key` to `function_key` for readability Co-authored-by: samugi <[email protected]>
ADD-SP
force-pushed
the
add_sp/fix-dynamic-hook
branch
from
08602ff to
3d83e47
Compare
ADD-SP
changed the title
chronolaw
approved these changes
May 27, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13085-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13085-to-master-to-upstream
git checkout -b cherry-pick-13085-to-master-to-upstream
ancref=$(git merge-base 1d1056e3d9ed0d6c51bc59695a12a3faf7b3fc6d 3d83e4713194db9576586ae3391b14b756ec9b0b)
git cherry-pick -x $ancref..3d83e4713194db9576586ae3391b14b756ec9b0b |
github-actions
bot
added
the
incomplete-cherry-pick
ADD-SP
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REBASE AND MERGE
Summary
Please review commit-by-commit. This PR did some style cleaning, fixed some bugs, and removed unused features.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4590