fix(redis): remove unnecessary redis config deprecation warnings in hybrid mode #13069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
3 times, most recently
from
4fb1831 to
f9205bc
Compare
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
2 times, most recently
from
3ae6528 to
7d74245
Compare
nowNick
changed the title
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
3 times, most recently
from
e42414b to
ffa5ff8
Compare
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
from
ffa5ff8 to
6bd05d3
Compare
samugi
reviewed
Jun 20, 2024
changelog/unreleased/kong/fix-acme-misleading-deprecation-logs.yml
Outdated
Show resolved
Hide resolved
changelog/unreleased/kong/fix-response-rl-misleading-deprecation-logs.yml
Outdated
Show resolved
Hide resolved
changelog/unreleased/kong/fix-rl-misleading-deprecation-logs.yml
Outdated
Show resolved
Hide resolved
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
2 times, most recently
from
a2576df to
daea999
Compare
|
@fffonion - could you elaborate a bit why you removed the label |
|
@nowNick I deleted the |
|
Oh ok. I read the thread but I was confused why only the 3.6 backport flag was removed. Thanks for letting me know 👍 |
samugi
reviewed
Jun 25, 2024
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
from
daea999 to
1c39467
Compare
When running kong in hybrid mode a plugin configuration is pushed from CP to DP. When introducing shorthand field expansion to Admin responses the deprecated fields (defined as shorthand fields) were also pushed from CP to DP which resulted in DP receiving config with both new fields and also old fields. It resulted with DP reporting in logs that the plugin is being configured with deprecated fields. It affected the plugins: - ACME - Rate-Limiting - Response-RateLimiting This commit disables deprecation warning on data planes since those nodes cannot be configured manually so this deprecation message is not actionable on data planes. KAG-4515
nowNick
force-pushed
the
fix/misleading-redis-config-deprecation-warnings
branch
from
1c39467 to
5a9b463
Compare
gszr
approved these changes
Jun 26, 2024
|
Successfully created cherry-pick PR for |
3 tasks
|
Successfully created backport PR for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running kong in hybrid mode with ACME plugin the configuration for the plugin is being pushed from CP to DP. When introducing shorthand field expansion to Admin API responses the deprecated fields (defined as shorthand fields) were also pushed from CP to DP which resulted in DP receiving config with both new fields and also old fields. It resulted with DP reporting in logs that ACME plugin is being configured with deprecated fields.
This PR disables the deprecation logs in DPs. The reasoning behind that is that those deprecation logs are not actionable on DP side and should be actually changed on CP if they were indeed configured improperly.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4515