tests(dns): fix the flakiness of the individual_toip test case #13060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
changed the title
chobits
force-pushed
the
chore/flaky-individual_toip
branch
from
151625e to
fe2feed
Compare
chronolaw
approved these changes
May 23, 2024
StarlightIbuki
approved these changes
May 23, 2024
|
Successfully created cherry-pick PR for |
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original test cases calls
toipwith the default option:order=LAST,SRV,A,CNAME, resulting in 3 queries (SRV, SRV-dereference(CNAME), A) each time we call toip, but it actually expects single query each time.Checklist
A changelog file has been created underchangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-4520