refactor(concurrency): consistent node-level locks #13055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
core/db
cherry-pick kong-ee
samugi
force-pushed
the
refactor/concurrency-worker-mutex
branch
from
5119f87 to
4442aa2
Compare
Several places in the gateway need a node-level lock, some of them used slightly different implementations. This refactor brings consistency in the ways we do node-level locking by using the same implementation (concurrency.with_worker_mutex) everywhere.
samugi
force-pushed
the
refactor/concurrency-worker-mutex
branch
from
4442aa2 to
5755745
Compare
nowNick
reviewed
Jul 2, 2024
nowNick
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Now it all makes sense! Thank you for explanation 🙇 . I went through the logic here and in the libs you mentioned and everything looks good to me 👍
I just left one comment that's not really related to your refactor. I was just curious what 0.001 means. If you know - maybe you can extract it to a constant and give it a name?
gruceo
approved these changes
Jul 11, 2024
|
Successfully created cherry-pick PR for |
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several places in the gateway need a node-level lock, some of them used slightly different implementations. This refactor brings consistency in the ways we do node-level locking by using the same implementation (concurrency.with_worker_mutex) everywhere.
Note: in order to maintain the logic of
declarative.importunaltered, theconcurrency.with_worker_mutexfunction has been slightly modified to return an additional valuettlin case of timeout error, so thatretry_aftercould be implemented as before.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-2337