Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): remove EOL distros, cleanup alpine and crossbuild aws2 #13052

Merged
merged 6 commits into from
Jul 9, 2024
Merged

fix(build): remove EOL distros, cleanup alpine and crossbuild aws2 #13052

merged 6 commits into from
Jul 9, 2024

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented May 21, 2024 •
edited
Loading

Please review each commits individually.

Summary

  • Remove alpine related code due to Kong 3.3 EOL. The commit should not be backported to 2.8 branch.
  • Remove RHEL7 and Debian10 (planned June 2024).
  • Cross build AWS2 x86_64.
  • As RHEL7 is removed and AWS2 is cross built, we can now safely bump actions/*@v3 to v4 that uses node 20.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4549

@fffonion fffonion changed the title Distros fix(build): remove EOL distros, cleanup alpine and crossbuild aws2 May 21, 2024
@github-actions github-actions bot added core/docs chore Not part of the core functionality of kong, but still needed build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 21, 2024
@fffonion
Copy link
Contributor Author

fffonion commented May 21, 2024 •
edited
Loading

good run https://github.com/Kong/kong/actions/runs/9185097568/job/25258635958?pr=13052

@fffonion fffonion force-pushed the distros branch 2 times, most recently from d72de42 to b25ad70 Compare May 21, 2024 10:28
@fffonion fffonion marked this pull request as ready for review May 30, 2024 06:18
@AndyZhang0707
Copy link
Collaborator

Let's wait for the final decision on the OS support policy from product team before we merge this PR.

@AndyZhang0707 AndyZhang0707 marked this pull request as draft May 31, 2024 08:54
@fffonion fffonion marked this pull request as ready for review July 2, 2024 06:21
@fffonion fffonion merged commit 26ec561 into master Jul 9, 2024
25 checks passed
@fffonion fffonion deleted the distros branch July 9, 2024 07:57
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jul 9, 2024
@Kong Kong deleted a comment from team-gateway-bot Jul 9, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jul 9, 2024
@AndyZhang0707 AndyZhang0707 mentioned this pull request Jul 23, 2024
Merged
3 tasks
@Water-Melon Water-Melon mentioned this pull request Aug 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@windmgc windmgc windmgc approved these changes

Assignees

@fffonion fffonion

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed core/docs size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fffonion @AndyZhang0707 @windmgc @Water-Melon @kikito