fix(aws-lambda): add missing version field into aws gateway compatible payload #13018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/aws-lambda
cherry-pick kong-ee
tzssangglass
approved these changes
May 14, 2024
ms2008
reviewed
May 14, 2024
changelog/unreleased/kong/fix-aws-lambda-gateway-compat-version-field.yml
Outdated
Show resolved
Hide resolved
…n-field.yml Co-authored-by: Yufu Zhao <[email protected]>
ms2008
approved these changes
May 14, 2024
|
Successfully created cherry-pick PR for |
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
…e payload (#13018) This PR adds a missing version field into the aws-lambda plugin's awsgateway_compatible payload. The awsgateway_compatible field provides a way to send a wrapped request body which is compatible with the format of AWS API gateway's proxy integration. The format of the payload is described here: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html#http-api-develop-integrations-lambda.proxy-format Some framework/projects that used to build Lambda function may check the version field sent by API gateway, so that they can apply different extracting logic according to different versions of payload. For example the logic in mangum looks like: https://github.com/jordaneremieff/mangum/blob/6086c268f32571c01f18e20875430db14a0570bc/mangum/handlers/api_gateway.py#L157-L176 The PR adds the missing version field for better compatibility. FTI-5949 (cherry picked from commit 204dd8d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a missing
versionfield into theaws-lambdaplugin'sawsgateway_compatiblepayload.The
awsgateway_compatiblefield provides a way to send a wrapped request body which is compatible with the format of AWS API gateway's proxy integration. The format of the payload is described here: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html#http-api-develop-integrations-lambda.proxy-formatSome framework/projects that used to build Lambda function may check the
versionfield sent by API gateway, so that they can apply different extracting logic according to different versions of payload. For example the logic inmangumlooks like: https://github.com/jordaneremieff/mangum/blob/6086c268f32571c01f18e20875430db14a0570bc/mangum/handlers/api_gateway.py#L157-L176The PR adds the missing
versionfield for better compatibility.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5949