-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ai-proxy): removed compat fields pre-3.7 #13006
Conversation
@@ -125,5 +125,27 @@ return { | |||
zipkin = { | |||
"propagation", | |||
}, | |||
ai_proxy = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm scared to change stuff that's working right now.
Can we chore this for later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's do it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: since this is covered by tests, removing checkers logic will confirm things are working the right way (i.e. via the removed_fields
) rather than through some other logic, so it would feel safer to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we remove twice, it feels safer to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m scared to remove this now that EE team will test and verify it, in case this package is doing something oddly specific.
I can add to 3.7.1 rollup and make sure it’s still fixed by hand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it's OK.
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13006-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13006-to-master-to-upstream
git checkout -b cherry-pick-13006-to-master-to-upstream
ancref=$(git merge-base f02d4efc35ff821f66deed7a60e27577865a0e9b 2f708be86283336d3272945daed27f5c9a21bbea)
git cherry-pick -x $ancref..2f708be86283336d3272945daed27f5c9a21bbea |
Successfully created backport PR for |
Add azure fields to removed_fields.lua to address CP/DP version compatibility issue reported at https://konghq.atlassian.net/browse/KAG-4356
Summary
Checklist
CHANGELOG/unreleased/kong
or addingskip-changelog
label on PR if unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/KAG-4356