-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router/atc): cleanup split routes and services #12990
Conversation
241f83e
to
4d700ce
Compare
7efba1d
to
8fae848
Compare
8fae848
to
d60ad2e
Compare
d60ad2e
to
199a117
Compare
This PR has almost the same logic as the original code, but it also introduces two extra tables, the complex data structure make the code hard to understand, we should add more comments for future's maintenance. |
It has less code than before and is also more performant, does less new table creations and clones, does not use pairs for looping. (On a potentially large 100.000 iteration loop). The exact same statement can be said on your original refactor. |
199a117
to
0ec9b25
Compare
@chronolaw comments were added. I also added another commit to clear the transformation functions. |
0ec9b25
to
8d50e0e
Compare
924b77e
to
069d44f
Compare
069d44f
to
da2ef2e
Compare
Signed-off-by: Aapo Talvensaari <[email protected]>
…x typos Signed-off-by: Aapo Talvensaari <[email protected]>
da2ef2e
to
db4e68d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you Aapo.
Successfully created cherry-pick PR for |
Summary
Just a slightly tighter code and reusing table.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
This was originally proposed at #12901 for inclusion in #12875.
REBASE AND MERGE