Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.6.x] fix(migrations): split redis migrations into up and teardown #12988

Merged
merged 1 commit into from
May 8, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.6.x, triggered by a label in #12983.

Original description

Summary

"UP" phase should only contain non-destructive operations. "TEARDOWN" (or "FINISH") phase should be used to change/delete data.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4419
#12978

"UP" phase should only contain non-destructive operations.
"TEARDOWN" (or "FINISH") phase should be used to change/delete data.

KAG-4419

(cherry picked from commit 49aa233)
@kikito kikito merged commit 1c24e91 into release/3.6.x May 8, 2024
51 checks passed
@kikito kikito deleted the backport-12983-to-release/3.6.x branch May 8, 2024 09:39
@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x: couldn't find remote ref release/3.6.x.
Please ensure that this Github repo has a branch named release/3.6.x.

@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x, because it was unable to create a new branch.

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/3.6.x
git worktree add -d .worktree/cherry-pick-12988-to-release/3.6.x-to-upstream upstream/release/3.6.x
cd .worktree/cherry-pick-12988-to-release/3.6.x-to-upstream
git checkout -b cherry-pick-12988-to-release/3.6.x-to-upstream
ancref=$(git merge-base b25f7e6bc6cdb0274038df64e1e7dedc7dcb1596 fd9186a52e378c7f3a810b764cd50af1c66053fd)
git cherry-pick -x $ancref..fd9186a52e378c7f3a810b764cd50af1c66053fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants