tests(deck): add deck integration tests #12980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
samugi
force-pushed
the
test/deck-integration
branch
from
848a0ac to
36d07e9
Compare
samugi
removed
the
cherry-pick kong-ee
github-actions
bot
added
core/admin-api
cherry-pick kong-ee
samugi
removed
the
cherry-pick kong-ee
samugi
force-pushed
the
test/deck-integration
branch
from
36d07e9 to
73e79bd
Compare
github-actions
bot
added
the
cherry-pick kong-ee
samugi
force-pushed
the
test/deck-integration
branch
2 times, most recently
from
96c451f to
24746fb
Compare
decK integration tests✅ passed successfully. |
samugi
force-pushed
the
test/deck-integration
branch
6 times, most recently
from
9cddf0c to
81fe3ce
Compare
samugi
removed
cherry-pick kong-ee
|
re-drafting to explore the option of using a review (by the bot) instead of a comment, to make the failures more visible when they occur Edit: done |
samugi
force-pushed
the
test/deck-integration
branch
from
81fe3ce to
8705c79
Compare
github-actions
bot
added
cherry-pick kong-ee
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
decK integration tests
samugi
force-pushed
the
test/deck-integration
branch
3 times, most recently
from
43ece33 to
edd4ea5
Compare
There was a problem hiding this comment.
decK integration tests
samugi
force-pushed
the
test/deck-integration
branch
from
d4f3389 to
c4d7cf0
Compare
bungle
approved these changes
Jun 10, 2024
jschmid1
approved these changes
Jun 11, 2024
These tests are meant to catch changes in Kong that result in incompatibilities with decK. The approach used here is to configure all the bundled plugins in Kong and a few other entities and confirm that deck dump + sync executes without errors. This new workflow "continues-on-error" instead of producing failures on CI: changes in gateway schemas might have to be merged despite making decK fail, the purpose of this is to notify about such incompatibilities. When those failures are detected, the workflow posts a review in the PR requesting changes and with a link to the failing run. The review is then dismissed if new changes are pushed to the PR that make the workflow pass.
samugi
force-pushed
the
test/deck-integration
branch
from
c4d7cf0 to
f03c57a
Compare
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These tests are meant to catch changes in Kong that result in incompatibilities with decK.
The approach used here is to configure all the bundled plugins in Kong and a few other entities and confirm that deck dump + sync executes without errors.
This new workflow "continues-on-error" instead of producing failures on CI: changes in gateway schemas might have to be merged despite making decK fail, the purpose of this is to notify about such incompatibilities. When those failures are detected, the workflow posts a review in the PR requesting changes, and a link to the failing run.
The review is then dismissed if new changes are pushed to the PR that make the workflow pass.<-- not anymore: branch protection rules prevent thisChecklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4236