Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/rpc): more strict parameter checking when generating a RPC error #12951

Merged
merged 6 commits into from
Jul 3, 2024
Merged

fix(clustering/rpc): more strict parameter checking when generating a RPC error #12951

merged 6 commits into from
Jul 3, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Apr 28, 2024 •
edited
Loading

Summary

minor code style improvement.

KAG-4441

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 28, 2024
@chronolaw chronolaw requested a review from ADD-SP April 28, 2024 02:04
@chronolaw chronolaw force-pushed the style/clustering_rpc_small_clean branch from e6cbce1 to 0526a2f Compare April 28, 2024 02:52
ADD-SP
ADD-SP previously approved these changes Apr 28, 2024
View reviewed changes
@bungle bungle changed the title style(clustering/rpc): minor code style improvment style(clustering/rpc): minor code style improvement Apr 29, 2024
@ADD-SP ADD-SP changed the title style(clustering/rpc): minor code style improvement fix(clustering/rpc): more strict parameter checking when generating a RPC error Apr 30, 2024
@ADD-SP ADD-SP dismissed their stale review April 30, 2024 03:11

With the past several changes, this PR became a fix, not style, needs more works.

@ADD-SP
Copy link
Contributor

ADD-SP commented Apr 30, 2024

Removed label skip-changelog as I would consider this PR is a fix.

@chronolaw chronolaw force-pushed the style/clustering_rpc_small_clean branch from 607212f to 4f26126 Compare July 1, 2024 01:51
@chronolaw chronolaw requested a review from ADD-SP July 3, 2024 02:29
ADD-SP
ADD-SP approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on CI green

@ADD-SP ADD-SP merged commit 4eeae00 into master Jul 3, 2024
29 of 30 checks passed
@ADD-SP ADD-SP deleted the style/clustering_rpc_small_clean branch July 3, 2024 03:37
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chobits chobits chobits approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @ADD-SP @team-gateway-bot @chobits