-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tools): update all references to tools.rand
#12932
Conversation
@bungle expressed concern about this change: Even though we don't like it, we need to consider that our customers use plugins that are forks of plugins that we wrote and that use internal functions, like those from I think we should rather audit all plugins that we can get our hands on to determine what internal functions they call, add those functions to the PDK and update the plugins to use them from there. Once we've done that, we can do the internal thing. We could also split up kong.utils, but keep the old interfaces for backwards compatibility. |
Should we revert this commit? 02aab49 |
rand
module out from utils
tools.rand
Makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
KAG-3143
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]