Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns): keep the force no sync option on recursive toip calls #12917

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

locao
Copy link
Contributor

@locao locao commented Apr 23, 2024

Summary

The force_no_sync option was missing in the recursive calls to execute_toip().

Skipping the changelog entry on this PR, as it is a fix for a feature not yet released.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-3795

@locao locao added skip-changelog cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 23, 2024
@locao locao added this to the 3.7.0 milestone Apr 23, 2024
@kikito kikito merged commit 8b22bec into master Apr 24, 2024
44 checks passed
@kikito kikito deleted the fix/toip_recursive_call branch April 24, 2024 07:58
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12917-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12917-to-master-to-upstream
git checkout -b cherry-pick-12917-to-master-to-upstream
ancref=$(git merge-base 6ff84c133e0edae3a023415699a58a6d3f84d163 fb401902ec89e4da320bd9b3e3e96f7cce972094)
git cherry-pick -x $ancref..fb401902ec89e4da320bd9b3e3e96f7cce972094

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 24, 2024
@locao locao removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants