fix(plugin): cleanup and fix error handling #12912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
Tieske
changed the title
samugi
approved these changes
May 8, 2024
tysoekong
approved these changes
May 8, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12912-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12912-to-master-to-upstream
git checkout -b cherry-pick-12912-to-master-to-upstream
ancref=$(git merge-base 36f13057244b3d6183610d6bbf92e3a98804264e 41246de744b85a70b4ff9d854e39a2c4039a965b)
git cherry-pick -x $ancref..41246de744b85a70b4ff9d854e39a2c4039a965b |
github-actions
bot
added
the
incomplete-cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
* chore(ai-prompt-template): cleanup code improve error handling * review comments (cherry picked from commit 0b1705e)
3 tasks
|
Successfully created backport PR for |
kikito
removed
the
incomplete-cherry-pick
samugi
pushed a commit
that referenced
this pull request
May 8, 2024
* chore(ai-prompt-template): cleanup code improve error handling * review comments (cherry picked from commit 0b1705e)
3 tasks
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
* chore(ai-prompt-template): cleanup code improve error handling * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the changelog is omitted, can go with the same entry as #12907
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md