Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.6.x] fix(tests): fix the flakiness caused by incomplete migration in the Vault tests #12894

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.6.x, triggered by a label in #12883.

Original description

Summary

Due to the inclusion of the following statement in the test code:

helpers.test_conf.loaded_plugins = {
  dummy = true,
}

This statement directly causes the load_subsystems function in kong/db/migrations/state.lua to only obtain the subsystems core and enterprise, which in turn causes most plugins to not undergo migration in helpers.get_db_utils. This ultimately leads to the issue when checking the migration of each plugin during start_kong.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4240

Sorry, something went wrong.

…ault tests (#12883)

KAG-4240

(cherry picked from commit 91afde0)
@bungle bungle merged commit 07abdd8 into release/3.6.x Apr 22, 2024
31 checks passed
@bungle bungle deleted the backport-12883-to-release/3.6.x branch April 22, 2024 13:23
@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x: couldn't find remote ref release/3.6.x.
Please ensure that this Github repo has a branch named release/3.6.x.

@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x, because it was unable to create a new branch.

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/3.6.x
git worktree add -d .worktree/cherry-pick-12894-to-release/3.6.x-to-upstream upstream/release/3.6.x
cd .worktree/cherry-pick-12894-to-release/3.6.x-to-upstream
git checkout -b cherry-pick-12894-to-release/3.6.x-to-upstream
ancref=$(git merge-base c51c3938587820f58443ff77297b96c27998406b 7cbde16e97f10d6eca9347cdf8cd13c7e0f80f42)
git cherry-pick -x $ancref..7cbde16e97f10d6eca9347cdf8cd13c7e0f80f42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants