Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): remove synchronize trigger for label-schema #12823

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

harrydt
Copy link
Member

@harrydt harrydt commented Apr 2, 2024

Summary

Currently, a Slack notification is sent to #gateway-schema-change-feed for every commit in a PR that has the label schema-change-noteworthy.
From the Koko side, we're only interested in the change as a whole (PR level). This change aims to reduce the duplicate messages and make it easier to keep track of gateway schema changes.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@harrydt harrydt closed this Apr 2, 2024
@harrydt harrydt reopened this Apr 2, 2024
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Apr 2, 2024
@harrydt harrydt force-pushed the ci/reduce_noise_label_schema branch from 2819c79 to aa6dfa2 Compare April 3, 2024 19:38
@flrgh flrgh added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 3, 2024
@zhongweiy
Copy link
Contributor

Looks good to me. I just want to confirm is it because we usually do the rebase for several times when the build failed, which is a synchronize event and generate too much message?

@harrydt
Copy link
Member Author

harrydt commented Apr 4, 2024

Looks good to me. I just want to confirm is it because we usually do the rebase for several times when the build failed, which is a synchronize event and generate too much message?

Yea, and also if new commits were pushed to head branch (the branch of the PR).
That's my understanding based on https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=synchronize#pull_request

A pull request's head branch was updated. For example, the head branch was updated from the base branch or new commits were pushed to the head branch.

In #gateway-schema-change-feed we usually get a notification for every new commit on the same PR.

@flrgh flrgh merged commit 015aa24 into master Apr 4, 2024
30 of 31 checks passed
@flrgh flrgh deleted the ci/reduce_noise_label_schema branch April 4, 2024 01:51
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@locao locao changed the title ci: remove synchronize trigger for label-schema chore(workflows): remove synchronize trigger for label-schema Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants