Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tools/system): move system module out of tools.utils #12813

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor(tools/system): move system module out of tools.utils #12813

merged 1 commit into from
Apr 2, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 30, 2024 •
edited
Loading

Summary

This is one of refactor kong.tools tasks.
KAG-3137

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 30, 2024
@chronolaw chronolaw requested a review from Water-Melon March 31, 2024 23:28
ADD-SP
ADD-SP reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any context about this PR?

@chronolaw
Copy link
Contributor Author

Any context about this PR?

Ticket added.

@ADD-SP ADD-SP merged commit 75fa2ae into master Apr 2, 2024
41 checks passed
@ADD-SP ADD-SP deleted the refactor/move_system_out_of_utils branch April 2, 2024 03:13
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @Water-Melon @ADD-SP