Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(tools/table): clean the comments and improve usage #12800

Merged
merged 2 commits into from
Apr 1, 2024
Merged

style(tools/table): clean the comments and improve usage #12800

merged 2 commits into from
Apr 1, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 28, 2024 •
edited
Loading

Summary

  • remove outdated comment
  • remove the usage of kong.tools.utils

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/db schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 28, 2024
@chronolaw chronolaw marked this pull request as ready for review March 28, 2024 09:15
@ADD-SP ADD-SP changed the title style(tools/table): clean the comments and usage of table_path style(tools/table): clean the comments and improve usage Apr 1, 2024
@ADD-SP ADD-SP merged commit 889c83d into master Apr 1, 2024
41 checks passed
@ADD-SP ADD-SP deleted the style/clean_usage_table_path branch April 1, 2024 02:10
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db schema-change-noteworthy size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @Water-Melon @ADD-SP