Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(hook): remove NYIs to be more JIT-friendly #12784

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Mar 26, 2024

Summary

  • Invoking a function using varargs (...) is NYI.

EE PR: kong/kong-ee#8046

Checklist

  • [N/A] The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-3653

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 26, 2024
@ADD-SP ADD-SP removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 26, 2024
@ADD-SP ADD-SP marked this pull request as ready for review March 26, 2024 08:25
kong/hooks.lua Outdated Show resolved Hide resolved
kong/hooks.lua Outdated Show resolved Hide resolved
kong/hooks.lua Outdated Show resolved Hide resolved
kong/hooks.lua Outdated Show resolved Hide resolved
kong/hooks.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP added backport release/3.3.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 26, 2024
@ADD-SP ADD-SP requested a review from chronolaw March 26, 2024 09:06
@AndyZhang0707 AndyZhang0707 requested a review from chobits March 26, 2024 09:43
@ADD-SP ADD-SP added this to the 3.7.0 milestone Mar 29, 2024
@ADD-SP ADD-SP force-pushed the add_sp/perf-rm-NYIs branch from 264e370 to 0fffe27 Compare March 31, 2024 00:22
@ADD-SP ADD-SP merged commit 20218e3 into master Apr 1, 2024
26 checks passed
@ADD-SP ADD-SP deleted the add_sp/perf-rm-NYIs branch April 1, 2024 06:37
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12784-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12784-to-master-to-upstream
git checkout -b cherry-pick-12784-to-master-to-upstream
ancref=$(git merge-base a7aeaa27178599cd4bfa32d4c787c502e43e6ee9 0fffe27e6c03a943ba029e2535acaaad78cad7ca)
git cherry-pick -x $ancref..0fffe27e6c03a943ba029e2535acaaad78cad7ca

ADD-SP added a commit that referenced this pull request Apr 8, 2024
…customer friendly

Make the changelog of #12784 more clear
ADD-SP added a commit that referenced this pull request Apr 8, 2024
…customer-friendly (#12837)

Make the changelog of #12784 more customer-friendly

KAG-3653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants