Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-lambda): add name format description for aws lambda plugin #12782

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Mar 25, 2024

Summary

This PR adds a detailed description for the function_name format of the aws-lambda plugin.

Checklist

  • [na] The Pull Request has tests
  • [na] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@windmgc windmgc force-pushed the docs-lambda-function-name branch from dfa320e to cf5b8dd Compare March 25, 2024 09:45
bungle
bungle previously requested changes Mar 26, 2024
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@windmgc windmgc requested a review from bungle March 27, 2024 07:52
Copy link
Contributor

@nowNick nowNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure this plugin is using lua-resty-aws which generates it's API based on: aws/aws-sdk-js and here we're using CreateFunctionCommand which as it's name accepts:

The name or ARN of the Lambda function.
Name formats

Function name – my-function.

Function ARN – arn:aws:lambda:us-west-2:123456789012:function:my-function.

Partial ARN – 123456789012:function:my-function.

The length constraint applies only to the full ARN. If you specify only the function name, it is limited to 64 characters in length.

Am I getting this right?

@windmgc
Copy link
Member Author

windmgc commented Mar 28, 2024

@nowNick All correct except the API we're using is actually InvokeFunction which invokes a Lambda function. But the function name format is the same, it is the same for all these APIs related to Lambda function. As long as AWS API supports that format we'll support that too

@windmgc windmgc dismissed bungle’s stale review April 7, 2024 09:27

fixed, dismiss

@windmgc windmgc merged commit aa8df3d into master Apr 7, 2024
26 checks passed
@windmgc windmgc deleted the docs-lambda-function-name branch April 7, 2024 09:27
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants