Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): busted script support system trusted certificate store #12770

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Mar 21, 2024

Summary

This PR makes bin/busted able to trust system certificate store for the convenience of some unit testing.

This is a partial cherry-picking from EE PR, although currently we don't have any OSS test that relies on this change, I created this cherry-picking PR just for keeping consistency between the two repos.

Checklist

  • [na] The Pull Request has tests
  • [na] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 21, 2024
@windmgc windmgc added skip-changelog and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 21, 2024
bin/busted Outdated Show resolved Hide resolved
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 21, 2024
@windmgc windmgc requested a review from bungle March 27, 2024 07:52
@ADD-SP ADD-SP requested review from zhongweiy and catbro666 April 1, 2024 02:42
@windmgc windmgc merged commit 88aa2c3 into master Apr 7, 2024
25 checks passed
@windmgc windmgc deleted the cherry-pick-bin-busted-fix branch April 7, 2024 09:02
@kikito kikito removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 16, 2024
@Kong Kong deleted a comment from team-gateway-bot Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants