Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/2.8.x] Backport 12691 to release/2.8.x #12713

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Water-Melon
Copy link
Contributor

chore(test): remove prefix directory when stop_kong called (#12691)

If the prefix is not cleaned up when stop_kong is called, it could impact subsequent tests, especially when later tests start Kong by a shell command, the Kong instance might be started up with the default servroot prefix.

KAG-3808

(cherry picked from commit 3dd5bdb)

Water-Melon and others added 2 commits March 8, 2024 10:50
If the prefix is not cleaned up when stop_kong is called,
it could impact subsequent tests, especially when later tests
start Kong by a shell command, the Kong instance might
be started up with the default `servroot` prefix.

KAG-3808

(cherry picked from commit 3dd5bdb)
@Water-Melon Water-Melon marked this pull request as ready for review March 8, 2024 11:08
@ADD-SP ADD-SP merged commit 5308d9e into release/2.8.x Mar 12, 2024
27 checks passed
@ADD-SP ADD-SP deleted the backport-12691-to-release/2.8.x branch March 12, 2024 02:52
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
* chore(test): remove prefix directory when stop_kong called (#12691)

If the prefix is not cleaned up when stop_kong is called,
it could impact subsequent tests, especially when later tests
start Kong by a shell command, the Kong instance might
be started up with the default `servroot` prefix.

KAG-3808

(cherry picked from commit 3dd5bdb)

* remove prefix directory for 2.8
locao pushed a commit that referenced this pull request Jun 22, 2024
Co-authored-by: Zachary Hu <[email protected]>
Co-authored-by: Niklaus Schen <[email protected]>
Co-authored-by: Zhongwei Yao <[email protected]>
Co-authored-by: samugi <[email protected]>
Co-authored-by: Water-Melon <[email protected]>
Co-authored-by: Michael Martin <[email protected]>
Co-authored-by: Kong Team Gateway Bot <[email protected]>
Co-authored-by: Zachary Hu <[email protected]>
Co-authored-by: Qi <[email protected]>
Co-authored-by: Mayo <[email protected]>
Co-authored-by: Wangchong Zhou <[email protected]>
Co-authored-by: Harry <[email protected]>
Co-authored-by: Datong Sun <[email protected]>
Co-authored-by: Vinicius Mignot <[email protected]>
fix directory when stop_kong called (#12713)
fix directory when stop_kong called (#12691)
fix the workflow that comments the docker image on the commit (#12693) (#12711)
fix(ci): replace "cpio" rpm extraction (#13233) (#13263)
fix label-check test (#9717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants