Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix flaky due to too close time for a timer #12696

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

StarlightIbuki
Copy link
Contributor

Summary

Timers do not always trigger precisely on time. Apply wait_until to stabilize the test.

Issue reference

Fix KAG-3224

Reworking #12318

Timers do not always trigger precisely on time. Apply wait_until to stabilize the test.

Fix KAG-3224
@StarlightIbuki StarlightIbuki force-pushed the chore/flaky-event-done-right branch from 497d50d to d7f8e4d Compare March 6, 2024 06:24
@StarlightIbuki StarlightIbuki requested review from kikito and ADD-SP March 6, 2024 06:24
@bungle bungle merged commit 15a3797 into master Mar 13, 2024
25 checks passed
@bungle bungle deleted the chore/flaky-event-done-right branch March 13, 2024 18:12
@AndyZhang0707 AndyZhang0707 added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 18, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

ADD-SP pushed a commit that referenced this pull request Jun 20, 2024
…mer (#13235)

For the test scenario of broadcasting an event with a delay (`broadcast(..., ..., delay)`), we need to apply wait_until to stabilize the test. Note that #12696 has fixed a similar issue, however, another one remains unresolved.

KAG-4764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants