chore(tests): add a test case for /metrics endpoint
#12695
+292
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case for `/metrics` endpoint. We expect the metrics endpoint can work weel even when database is down. And a db_proxy is added to spec/helpers for imitating database outage or performance decrease.
AndyZhang0707
force-pushed
the
database-outage-testcase
branch
from
b5fbe3b to
798a869
Compare
github-actions
bot
added
the
cherry-pick kong-ee
outsinre
reviewed
Mar 22, 2024
Comment on lines
11
to
14
| for _, strategy in helpers.all_strategies() do | ||
| describe("Metrics API - with strategy #" .. strategy, function() | ||
|
|
||
| if strategy == "postgres" then |
There was a problem hiding this comment.
We use helper.each_strategies() to avoid the `if strategy == "postgres".
windmgc
requested changes
Mar 22, 2024
spec/helpers.lua
Outdated
Comment on lines
4193
to
4194
| stream_listen = "0.0.0.0:5555", | ||
| proxy_listen = "0.0.0.0:16666", |
There was a problem hiding this comment.
If this is unused, will it be better just get_available_port?
Comment on lines
+4177
to
+4180
| db_port = opts.db_port, | ||
| db_proxy_port = get_available_port(), | ||
| api_port = get_available_port(), | ||
| tcp_port = get_available_port(), |
There was a problem hiding this comment.
These ports should have documentation describing their purposes
| } | ||
| end | ||
|
|
||
| function db_proxy:delay(delay) |
There was a problem hiding this comment.
A documentation describing how to use these functions would also be better
outsinre
approved these changes
Mar 25, 2024
liverpool8056
force-pushed
the
database-outage-testcase
branch
from
123eb83 to
ff7c582
Compare
catbro666
approved these changes
Jun 5, 2024
samugi
reviewed
Jul 5, 2024
| @@ -4156,6 +4156,243 @@ do | |||
| end | |||
| end | |||
|
|
|||
| -------------- | |||
| -- A kong based database proxy class for the simulation of database abnormal behavior. | |||
There was a problem hiding this comment.
would it make sense to move this to a separate file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A test case is added for testing
/metricsendpoint when database is down.And a db_proxy is added to spec/helpers for imitating database outage or performance decrease.
A related PR: https://github.com/Kong/kong-ee/pull/8321
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]