[backport -> release/3.6.x] hotfix(deps): enable JIT support for pcre2 #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCRE2 requires JIT support to be explicitly enabled during build. From https://pcre.org/current/doc/html/pcre2jit.html: "JIT support is an optional feature of PCRE2. The "configure" option --enable-jit (or equivalent CMake option) must be set when PCRE2 is built if you want to use JIT." Without the flag in this commit, Kong logs display several entries containing failures in `pcre2_jit_compile`, such as ``` 2024/01/30 16:25:20 [info] 747309#0: pcre2_jit_compile() failed: -45 in "^\s*HTTP/1\.1\s+", ignored ``` (cherry picked from commit cc25516)
bungle
approved these changes
Mar 4, 2024
samugi
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/3.6.x, triggered by a label in #12464.Original description
PCRE2 requires JIT support to be explicitly enabled during build. From https://pcre.org/current/doc/html/pcre2jit.html:
"JIT support is an optional feature of PCRE2. The "configure" option --enable-jit (or equivalent CMake option) must be set when PCRE2 is built if you want to use JIT."
Without the flag in this commit, Kong logs display several entries containing failures in
pcre2_jit_compile, such as