Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(db/schema): ensure to validate possible routes fields #12681

Merged
merged 2 commits into from
Mar 13, 2024
Merged

refactor(db/schema): ensure to validate possible routes fields #12681

merged 2 commits into from
Mar 13, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 4, 2024 •
edited by ADD-SP
Loading

Please REBASE AND MERGE

Summary

KAG-3922

FTI-5781 was fixed in #12650, this PR add the test cases and changelog.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chronolaw
Copy link
Contributor Author

blocked by #12650

@chronolaw chronolaw force-pushed the refactor/enforce_validation_of_flavor_compat branch from 4641be2 to 8d429a4 Compare March 6, 2024 03:12
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 6, 2024
@chronolaw chronolaw marked this pull request as ready for review March 6, 2024 05:48
@chronolaw chronolaw added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed skip-changelog labels Mar 6, 2024
@chronolaw chronolaw force-pushed the refactor/enforce_validation_of_flavor_compat branch from 3ff2c63 to 8c7343e Compare March 7, 2024 04:55
@ADD-SP ADD-SP force-pushed the refactor/enforce_validation_of_flavor_compat branch from 8c7343e to 8d165cb Compare March 7, 2024 06:19
chronolaw added 2 commits March 8, 2024 10:57
@chronolaw
refactor(router/atc): ensure to validate possible routes fields
7422900 
fix is_empty_field

add protocols for stream tests

tests for tls_passthrough

fix-snis-tls-passthrough-in-trad-compat.yml

style lint
@chronolaw
docs(changelog): add change log entry for #12650
087d1c5
@chronolaw chronolaw force-pushed the refactor/enforce_validation_of_flavor_compat branch from f0c41d5 to 087d1c5 Compare March 8, 2024 02:57
@AndyZhang0707 AndyZhang0707 requested a review from chobits March 13, 2024 02:35
@ADD-SP ADD-SP merged commit 5319aa7 into master Mar 13, 2024
28 checks passed
@ADD-SP ADD-SP deleted the refactor/enforce_validation_of_flavor_compat branch March 13, 2024 07:52
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/router schema-change-noteworthy size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @chobits @ADD-SP