Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router/atc): simplify searching for field accessor function #12664

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor(router/atc): simplify searching for field accessor function #12664

merged 1 commit into from
Feb 29, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Feb 28, 2024 •
edited
Loading

Summary

Move the FIELDS_FUNCS searching into function get_field_accessor(),
this will make code easy to understand.

KAG-3634

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

ADD-SP
ADD-SP approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 29, 2024
@ADD-SP ADD-SP merged commit dcf8711 into master Feb 29, 2024
48 checks passed
@ADD-SP ADD-SP deleted the refactor/simplify_get_value branch February 29, 2024 02:47
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @chobits @ADD-SP