Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): support directive for general shm_kv entry #12663

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

hishamhm
Copy link
Contributor

Summary

WasmX supports using non-namespaced entries in proxy-wasm get_shared_data and set_shared_data. For this, one needs to define a no-namespaced shm_kv using the shm_kv * <size> directive. This commit adds nginx_wasm_main_shm_kv as a supported option alongside the existing nginx_wasm_main_shm_kv_<namespace> entries, for definition of the non-namespaced shm_kv.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - this PR updates kong.conf.default with documentation on the new directive, from which the Docs site generates configuration documentation.

Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me.

@flrgh flrgh added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 29, 2024
WasmX supports using non-namespaced entries in proxy-wasm `get_shared_data`
and `set_shared_data`. For this, one needs to define a no-namespaced shm_kv
using the `shm_kv * <size>` directive. This commit adds
`nginx_wasm_main_shm_kv` as a supported option alongside the existing
`nginx_wasm_main_shm_kv_<namespace>` entries, for definition of the
non-namespaced `shm_kv`.
@locao locao force-pushed the feat/wasm-general-shm-kv branch from 8451975 to 247ef92 Compare March 22, 2024 15:17
@locao locao merged commit e0b825c into master Mar 22, 2024
26 checks passed
@locao locao deleted the feat/wasm-general-shm-kv branch March 22, 2024 17:45
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration core/templates size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants