fix(dns): resolv.conf options timeout: 0 is ignored #12640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/dns-client-options-timeout
branch
from
651b44c to
2ec79ab
Compare
chobits
reviewed
Feb 27, 2024
chobits
force-pushed
the
fix/dns-client-options-timeout
branch
from
2ec79ab to
5f2324b
Compare
bungle
force-pushed
the
fix/dns-client-options-timeout
branch
from
aa0c3fb to
a23379f
Compare
chobits
approved these changes
Feb 28, 2024
chobits
force-pushed
the
fix/dns-client-options-timeout
branch
from
a23379f to
3796a6b
Compare
flrgh
approved these changes
Feb 29, 2024
outsinre
reviewed
Mar 5, 2024
outsinre
reviewed
Mar 5, 2024
chobits
force-pushed
the
fix/dns-client-options-timeout
branch
from
3796a6b to
9fcb019
Compare
|
Just out of curiosity, is there any doc describing the special behaviour of |
outsinre
force-pushed
the
fix/dns-client-options-timeout
branch
from
9fcb019 to
9ed3a29
Compare
|
Seems different implementations behave not exactly the same. Regarding Kong DNS, reset |
bungle
added
the
cherry-pick kong-ee
### Summary The `options timeout: 0` has a specific meaning in `resolv.conf`. It means that the request will be sent to all nameservers without waiting and whoever answers first, will be accepted. In Kong the `options timeout: 0` cause actually all the DNS queries themselves to timeout. This is bad as some platforms tend to follow `options timeout: 0` as a good practice when having more than one resolver. Kong should in future support parallel thread based resolving from multiple resolvers, but first we need to get this fix to stop it causing issues. Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
fix/dns-client-options-timeout
branch
from
352e16b to
43fa876
Compare
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
options timeout: 0has a specific meaning inresolv.conf. It means that the request will be sent to all nameservers without waiting and whoever answers first, will be accepted.In Kong the
options timeout: 0cause actually all the DNS queries themselves to timeout. This is bad as some platforms tend to followoptions timeout: 0as a good practice when having more than one resolver.Kong should in future support parallel thread based resolving from multiple resolvers, but first we need to get this fix to stop it causing issues.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFix FTI-5791