Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add commit linter workflow #12621

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(ci): add commit linter workflow #12621

merged 1 commit into from
Feb 27, 2024

Conversation

gszr
Copy link
Member

@gszr gszr commented Feb 25, 2024

Summary

Enforce commit message format.

Docs: https://github.com/ahmadnassri/action-commit-lint?tab=readme-ov-file#built-in-configs

Feel free to add new commits testing the linter.

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 25, 2024
@gszr gszr force-pushed the ci/add-commit-lint branch from 08343de to 6854b53 Compare February 27, 2024 11:24
@gszr gszr marked this pull request as ready for review February 27, 2024 11:24
Enforce commit message format.
@gszr gszr force-pushed the ci/add-commit-lint branch from 6854b53 to 3cc6cc7 Compare February 27, 2024 11:27
@gszr gszr changed the title chore(ci): add commit lint chore(ci): add commit linter workflow Feb 27, 2024
steps:
- uses: ahmadnassri/action-commit-lint@v2
with:
config: conventional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional#type-enum
It seems that there is no hotfix item. I am not sure if hotfix is still in use now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not seen that distinction being made in the recent past at least. I am very much in favor of simplifying and automating things.

@locao locao merged commit 6c9f44a into master Feb 27, 2024
29 checks passed
@locao locao deleted the ci/add-commit-lint branch February 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants