Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build and test use github token #12618

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(ci): build and test use github token #12618

merged 1 commit into from
Mar 5, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented Feb 23, 2024

Summary

replace PAT with github_token

background: when I opened this PR PAT had expired and it was making some tests fail on CI. It has since been rotated and things are green again now.

We can still merge this and use github_token for this workflow instead to avoid this problem in the future.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@samugi samugi marked this pull request as draft February 23, 2024 17:46
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 23, 2024
@samugi samugi marked this pull request as ready for review February 23, 2024 17:49
replace PAT with github_token
@locao locao force-pushed the fix/scheduler-token branch from 585a5be to 3f546f0 Compare March 5, 2024 18:12
@locao locao merged commit 9566dd9 into master Mar 5, 2024
17 checks passed
@locao locao deleted the fix/scheduler-token branch March 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants