chore(tests): remove redis >= v6 checks in tests #12617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowNick
force-pushed
the
chore/remove-redis-6-checks-in-tests
branch
from
fa9253c to
d71cd2e
Compare
nowNick
force-pushed
the
chore/remove-redis-6-checks-in-tests
branch
2 times, most recently
from
1d5ad41 to
6df21fd
Compare
hanshuebner
approved these changes
Feb 26, 2024
ADD-SP
approved these changes
Feb 26, 2024
There were a lot of checks for redis version being at least 6.0.0 It's been 4 years since redis 6.0.0 release and we don't test against lower versions anymore so these checks are no longer needed. KAG-2130
nowNick
force-pushed
the
chore/remove-redis-6-checks-in-tests
branch
from
6df21fd to
93600cd
Compare
nowNick
added
the
cherry-pick kong-ee
jschmid1
approved these changes
Feb 26, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12617-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12617-to-master-to-upstream
git checkout -b cherry-pick-12617-to-master-to-upstream
ancref=$(git merge-base 7473c81c936c79037f6a5266f9b42a35de2275a5 93600cdccd2a1af515850ae747e0aa766f7fc251)
git cherry-pick -x $ancref..93600cdccd2a1af515850ae747e0aa766f7fc251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were a lot of checks for redis version being at least 6.0.0 It's been 4 years since redis 6.0.0 release and we don't test against lower versions anymore (as far as I checked) so these
ifs are no longer needed.I highly recommend viewing the diff with Hide whitespace setting turned on.
Checklist
The Pull Request has testsA changelog file has been created underchangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
KAG-2130