Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): update changelog for gRPC TLS seclevel change #12613

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon commented Feb 23, 2024

Update changelog for gRPC TLS seclevel change. The original PR is #12548.

Set security level of gRPC's TLS to 0 when ssl_cipher_suite is set to old.

KAG-3259

@Water-Melon Water-Melon added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 23, 2024
@Water-Melon Water-Melon marked this pull request as ready for review February 23, 2024 08:41
@Water-Melon Water-Melon force-pushed the chore/update_changelog_for_grpc_tls_seclevel branch from ea9c7fd to aa0fe90 Compare February 23, 2024 08:42
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let the message start with a verb, otherwise I'm having trouble understanding what this PR has done.

changelog/unreleased/kong/set_grpc_tls_seclevel.yml Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the chore/update_changelog_for_grpc_tls_seclevel branch from aa0fe90 to e68aa2b Compare February 23, 2024 09:04
@Water-Melon Water-Melon requested a review from ADD-SP February 23, 2024 09:07
@Water-Melon Water-Melon force-pushed the chore/update_changelog_for_grpc_tls_seclevel branch from e68aa2b to c2745d3 Compare February 23, 2024 09:13
@ADD-SP ADD-SP merged commit a759f5a into master Feb 23, 2024
6 checks passed
@ADD-SP ADD-SP deleted the chore/update_changelog_for_grpc_tls_seclevel branch February 23, 2024 10:00
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@Water-Melon Water-Melon restored the chore/update_changelog_for_grpc_tls_seclevel branch February 23, 2024 10:26
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12613-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12613-to-master-to-upstream
git checkout -b cherry-pick-12613-to-master-to-upstream
ancref=$(git merge-base 31926752d792f92718f04b8f424ef2b7f6dd8080 c2745d3c30e2ae1587c3ed27d34831faa066a212)
git cherry-pick -x $ancref..c2745d3c30e2ae1587c3ed27d34831faa066a212

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12613-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12613-to-master-to-upstream
git checkout -b cherry-pick-12613-to-master-to-upstream
ancref=$(git merge-base 31926752d792f92718f04b8f424ef2b7f6dd8080 c2745d3c30e2ae1587c3ed27d34831faa066a212)
git cherry-pick -x $ancref..c2745d3c30e2ae1587c3ed27d34831faa066a212

1 similar comment
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12613-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12613-to-master-to-upstream
git checkout -b cherry-pick-12613-to-master-to-upstream
ancref=$(git merge-base 31926752d792f92718f04b8f424ef2b7f6dd8080 c2745d3c30e2ae1587c3ed27d34831faa066a212)
git cherry-pick -x $ancref..c2745d3c30e2ae1587c3ed27d34831faa066a212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants