fix(api): avoid returning 405 on /schemas/vaults/:name #12607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruceo
force-pushed
the
fix/kag-3699
branch
2 times, most recently
from
7a643cd to
96967f8
Compare
gruceo
changed the title
gruceo
force-pushed
the
fix/kag-3699
branch
2 times, most recently
from
afcdb0b to
7fe1d7b
Compare
bungle
approved these changes
Feb 23, 2024
oowl
approved these changes
Feb 23, 2024
This fixes an issue where calling the endpoint `POST /schemas/vaults/validate` was conflicting with the endpoint `/schemas/vaults/:name` which only has GET implemented, hence resulting in a 405. By explicting defining a new endpoint `/schemas/vaults/validate`, Lapis framework should take care of always choosing it over `/schemas/vaults/:name`. KAG-3699
locao
approved these changes
Feb 23, 2024
gruceo
added
the
cherry-pick kong-ee
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where calling the endpoint
POST /schemas/vaults/validatewas conflicting with the endpoint
/schemas/vaults/:namewhich onlyhas GET implemented, hence resulting in a 405.
By explicting defining a new endpoint
/schemas/vaults/validate, Lapisframework should take care of always choosing it over
/schemas/vaults/:name.Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-3699