Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.6.x] chore(conf): enable grpc_ssl_conf_command too (#12548) #12590

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Water-Melon
Copy link
Contributor

#12548

Summary

The #12420 by @Water-Melon forgot to add grpc_ssl_conf_command. This commit adds that.

Signed-off-by: Aapo Talvensaari [email protected]
(cherry picked from commit 84cb1be)

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

### Summary

The #12420 by @Water-Melon forgot to add `grpc_ssl_conf_command`.
This commit adds that.

Signed-off-by: Aapo Talvensaari <[email protected]>
(cherry picked from commit 84cb1be)
Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note nginx still contains two other ssl related command:

uwsgi_ssl_conf_command
zone_sync_ssl_conf_command

I cheched the repo and didnt find we use these modules uwsgi and zone in kong via grep zone/uwsgi -R kong

@Water-Melon
Copy link
Contributor Author

@chobits
Yes.
I haven't seen them either.
Also, these two don't seem to be native configuration directives in Nginx. If they need to be added later, we'll open a new PR to handle them.

@ms2008 ms2008 merged commit 3a8fb78 into release/3.6.x Feb 21, 2024
35 of 37 checks passed
@ms2008 ms2008 deleted the backport-12548-to-release/3.6.x branch February 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants