Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.5.x] fix(vault): postpone vault reference resolving on init_worker #12585

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.5.x, triggered by a label in #12554.

Original description

Summary

It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker:

resty/http.lua:74: API disabled in the context of init_worker_by_lua*
stack traceback:
	[C]: in function 'co_create'

This fixes the issue by postponing the resolving to a timer.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

https://konghq.atlassian.net/browse/KAG-2907

### Summary

It was reported on KAG-2907 that existing LMDB database with secrets
can lead to an error when resolving secrets on init worker:

```
resty/http.lua:74: API disabled in the context of init_worker_by_lua*
stack traceback:
	[C]: in function 'co_create'
```

This fixes the issue.

Signed-off-by: Aapo Talvensaari <[email protected]>
(cherry picked from commit 9a7498c)
@windmgc windmgc merged commit 4d3cd10 into release/3.5.x Mar 5, 2024
40 checks passed
@windmgc windmgc deleted the backport-12554-to-release/3.5.x branch March 5, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/pdk core/wasm Everything relevant to [proxy-]wasm schema-change-noteworthy size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants