feat(vault): add file system (fs) vault #12584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/fs-vault
branch
4 times, most recently
from
723864a to
93bbb58
Compare
bungle
force-pushed
the
feat/fs-vault
branch
from
93bbb58 to
a04449f
Compare
### Summary Adds a file system vault. Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
feat/fs-vault
branch
from
a04449f to
dceb658
Compare
|
@bungle News from the red cord. Could we hold off on this for a little while until we clarify requirements? They've shifted since you built this |
bungle
added
the
pr/ready (but hold merge)
team-eng-enablement
added
author/community
|
Converting to draft, pending final requirements |
|
@GGabriele we never got final requirements. Should we go ahead and merge this? |
|
That would be fine to me, but maybe @mheap knows more? |
|
Let’s close until there’s a concrete need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a file system vault.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3736