Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): fix otel sampling mode lua panic bug when http_response_header_for_traceid option enable #12544

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Feb 7, 2024

Summary

When the OpenTelemetry plugin was enabled on the default workspace, it would crash for requests to nonexistent routes.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-5742

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Feb 7, 2024
@hanshuebner hanshuebner added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 12, 2024
@hanshuebner hanshuebner merged commit d48c63d into master Feb 12, 2024
28 checks passed
@hanshuebner hanshuebner deleted the fix-otel-502 branch February 12, 2024 08:13
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/opentelemetry size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants