[backport -> release/3.6.x] fix(dao): allow shorthand fields to be in response #12543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorthand fields are stripped out of response but we're using them when we want to rename some of the fields. This commit adds an option `expand_shortfields` as well as some some options to shorthand_fields schema that would allow us to include them back in the schema while using the latest data KAG-3677 (cherry picked from commit c76b943)
team-gateway-bot
added
cherry-pick kong-ee
3 tasks
nowNick
approved these changes
Feb 6, 2024
jschmid1
approved these changes
Feb 6, 2024
|
Cherry-pick failed for |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/3.6.x
git worktree add -d .worktree/cherry-pick-12543-to-release/3.6.x-to-upstream upstream/release/3.6.x
cd .worktree/cherry-pick-12543-to-release/3.6.x-to-upstream
git checkout -b cherry-pick-12543-to-release/3.6.x-to-upstream
ancref=$(git merge-base 1ec5948565b83ebc9bcc5405b7d2a52369716a01 ceba9857d48e91c9263101dec50c0a1f1effa48b)
git cherry-pick -x $ancref..ceba9857d48e91c9263101dec50c0a1f1effa48b |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/3.6.x, triggered by a label in #12537.Original description
Summary
Shorthand fields are stripped out of response but we're using them when we want to rename some of the fields. This commit adds an option
expand_shortfieldsas well as some some options toshorthand_fieldsschema that would allow us to include them back in the schema while using the latest dataChecklist
A changelog file has been created underchangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
KAG-3677