fix(balancer): ensure the notify callback is invoked only if defined when handling cached connection errors
#12468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when handling cached connection errors address comments of #12346 Signed-off-by: tzssangglass <[email protected]>
tzssangglass
added
the
cherry-pick kong-ee
Signed-off-by: tzssangglass <[email protected]>
|
new Review patches for Kong:fix_max_retry: https://github.com/Kong/openresty-patches-review/pull/37 |
chobits
approved these changes
Jan 31, 2024
chronolaw
approved these changes
Jan 31, 2024
|
hi @tzssangglass do you add other function diff in this pr? we need to make sure we only modify the notify verification and one typo. Other feature could be add to 3.7 |
fix as comments, view diff by: https://github.com/Kong/openresty-patches-review/pull/37 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
…d when handling cached connection errors (#12468) * fix(balancer): ensure the `notify` callback is invoked only if defined when handling cached connection errors address comments of #12346 Signed-off-by: tzssangglass <[email protected]> * fix Signed-off-by: tzssangglass <[email protected]> --------- Signed-off-by: tzssangglass <[email protected]> (cherry picked from commit 415ca0f)
3 tasks
|
Successfully created backport PR for |
kikito
pushed a commit
that referenced
this pull request
Jan 31, 2024
…d when handling cached connection errors (#12468) * fix(balancer): ensure the `notify` callback is invoked only if defined when handling cached connection errors address comments of #12346 Signed-off-by: tzssangglass <[email protected]> * fix Signed-off-by: tzssangglass <[email protected]> --------- Signed-off-by: tzssangglass <[email protected]> (cherry picked from commit 415ca0f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address comments of #12346
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-5616