-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tracing): simplified the dynamic hooks code #12461
Conversation
9f3845c
to
757cae6
Compare
The non-varargs optimization can be added if neccessary. (Edit: I added small optimization for that on second commit). |
f6d2e4a
to
1aa69c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we need to profile and benchmark this PR, could you please convert this PR as a draft?
1aa69c0
to
405db06
Compare
Converted to draft. |
91b3278
to
da9c200
Compare
36f1109
to
6bb8e66
Compare
6bb8e66
to
4db90f5
Compare
Rebased on master. |
ab85eeb
to
2c24ef1
Compare
c43fb35
to
c0594ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove the first argument at the definition of run_hooks()
Line 325 in d43159a
req_dyn_hook_run_hooks(ctx, "timing", "before:plugin_iterator") |
c0594ee
to
d0d75dd
Compare
I have removed the |
Signed-off-by: Aapo Talvensaari <[email protected]>
d0d75dd
to
7ca1742
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12461-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12461-to-master-to-upstream
git checkout -b cherry-pick-12461-to-master-to-upstream
ancref=$(git merge-base 29285c3867038b66a57591ae09b640f92c35c4a0 7ca1742dcd1a2113a3e8a7e9be833fa7c6a16895)
git cherry-pick -x $ancref..7ca1742dcd1a2113a3e8a7e9be833fa7c6a16895 |
Summary
Removes ugly code generation with simple local functions.
KAG-3870