Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(router): use static functions for callbacks #12448

Merged
merged 5 commits into from
Jan 30, 2024
Merged

perf(router): use static functions for callbacks #12448

merged 5 commits into from
Jan 30, 2024

Conversation

bungle
Copy link
Member

@bungle bungle commented Jan 29, 2024

Summary

Just a small refactor of code to use static functions.

@bungle bungle requested a review from chronolaw January 29, 2024 15:37
@bungle bungle force-pushed the perf/router-fields branch 3 times, most recently from d754f14 to eea38b5 Compare January 29, 2024 15:50
@bungle bungle force-pushed the perf/router-fields branch from eea38b5 to 5731912 Compare January 29, 2024 17:12
@bungle bungle marked this pull request as ready for review January 29, 2024 18:12
@chronolaw
Copy link
Contributor

This PR can work, but the usage of ctx is a little confusing, I think that it should be a concept proof, and need some improvements.

@chronolaw chronolaw added the pr/discussion This PR is being debated. Probably just a few details. label Jan 30, 2024
@chronolaw chronolaw added this to the 3.6.0 milestone Jan 30, 2024
@chobits
Copy link
Contributor

chobits commented Jan 30, 2024 •
edited
Loading

Some perf result on 3.6.0.0.rc.2

  • 3.6.0.0.rc.2 + aapo pr#12448
    • Requests/sec: 11473.68 /foo?param1=1argsparam2=2
    • Requests/sec: 11454.73 /foo?param1=1argsparam2=2
    • Requests/sec: 11530.51 /foo?param1=1argsparam2=2
  • 3.6.0.0.rc.2
    • Requests/sec: 10967.88 /foo?param1=1argsparam2=2
    • Requests/sec: 11142.79 /foo?param1=1argsparam2=2
    • Requests/sec: 11048.18 /foo?param1=1argsparam2=2
    • Requests/sec: 11107.94 "/"
    • Requests/sec: 11241.47 "/"
  • 3.6.0.0.rc.2 + aapo pr#12448
    • Requests/sec: 11597.62 "/"
    • Requests/sec: 11525.54 "/"

@kikito kikito merged commit 30096f3 into master Jan 30, 2024
28 checks passed
@kikito kikito deleted the perf/router-fields branch January 30, 2024 08:53
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@bungle @github-actions
perf(router): use static functions for callbacks (#12448)
77f335e 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
(cherry picked from commit 30096f3)
@team-gateway-bot team-gateway-bot mentioned this pull request Jan 30, 2024
Merged
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.6.x:

@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 30, 2024
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.6.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

chronolaw added a commit that referenced this pull request Jan 30, 2024
@bungle @chronolaw
perf(router): use static functions for callbacks (#12448)
5c96d34 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
chronolaw added a commit that referenced this pull request Jan 30, 2024
@bungle @chronolaw
perf(router): use static functions for callbacks (#12448)
e0a4e6a 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
bungle added a commit that referenced this pull request Jan 30, 2024
@bungle
perf(router): use static functions for callbacks (#12448)
8d27ad1 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
(cherry picked from commit 30096f3)
This was referenced Feb 2, 2024
Merged
Merged
chronolaw added a commit that referenced this pull request Feb 26, 2024
@bungle @chronolaw
perf(router): use static functions for callbacks (#12448)
f87f0e0 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
chronolaw added a commit that referenced this pull request Feb 26, 2024
@bungle @chronolaw
perf(router): use static functions for callbacks (#12448)
0b38029 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
chronolaw added a commit that referenced this pull request Mar 4, 2024
@bungle @chronolaw
perf(router): use static functions for callbacks (#12448)
1543f9f 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
locao pushed a commit that referenced this pull request Mar 5, 2024
@bungle @chronolaw @locao
perf(router): use static functions for callbacks (#12448)
24480f4 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@bungle @chronolaw @ADD-SP
perf(router): use static functions for callbacks (#12448)
74f7933 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@bungle @chronolaw @ADD-SP
perf(router): use static functions for callbacks (#12448)
25aa629 
* perf(router): use static functions for callbacks

Signed-off-by: Aapo Talvensaari <[email protected]>

* tuning some code

* style clean

* style clean

* style clean

---------

Signed-off-by: Aapo Talvensaari <[email protected]>
Co-authored-by: chronolaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@chobits chobits chobits approved these changes

@kikito kikito kikito approved these changes

Assignees

@bungle bungle

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router pr/discussion This PR is being debated. Probably just a few details. size/L skip-changelog
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bungle @chronolaw @chobits @team-gateway-bot @kikito