Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins): consistent error responses upon Admin API auth failures #12429

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(plugins): consistent error responses upon Admin API auth failures #12429

merged 2 commits into from
Jan 30, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jan 26, 2024 •
edited
Loading

Summary

Unifying error responses when admin authentication via Admin/Portal API is failed.

Cherry-picks: https://github.com/Kong/kong-ee/pull/6552

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • n/a There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix SEC-912 / KAG-1672

@sumimakito
Copy link
Member Author

Cherry-picking this as we forgot to include these changes in CE.

@sumimakito sumimakito added this to the 3.6.0 milestone Jan 26, 2024
nekolab
nekolab approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyZhang0707 AndyZhang0707 merged commit 60ea714 into master Jan 30, 2024
25 checks passed
@AndyZhang0707 AndyZhang0707 deleted the fix/SEC-912-KAG-1672-unify-admin-auth-error-response branch January 30, 2024 07:16
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12429-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12429-to-release/3.5.x
git switch --create backport-12429-to-release/3.5.x
git cherry-pick -x 60ea714e124ec81bef97031b9d334febcfa9303b

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@sumimakito @github-actions
fix(plugins): consistent error responses upon Admin API auth failures (…
5fc9dbd 
…#12429)

* fix(plugins): consistent error responses upon Admin API auth failures

* fix(basic-auth): update error message

(cherry picked from commit 60ea714)
@team-gateway-bot team-gateway-bot mentioned this pull request Jan 30, 2024
Merged
3 tasks
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.6.x:

sumimakito added a commit that referenced this pull request Jan 30, 2024
@sumimakito
fix(plugins): consistent error responses upon Admin API auth failures (…
354b2e0 
…#12429)

* fix(plugins): consistent error responses upon Admin API auth failures

* fix(basic-auth): update error message

(cherry picked from commit 60ea714)
@sumimakito sumimakito mentioned this pull request Jan 30, 2024
Merged
locao pushed a commit that referenced this pull request Mar 19, 2024
@sumimakito @locao
fix(plugins): consistent error responses upon Admin API auth failures (…
93c7437 
…#12429)

* fix(plugins): consistent error responses upon Admin API auth failures

* fix(basic-auth): update error message

(cherry picked from commit 60ea714)
locao pushed a commit that referenced this pull request Mar 19, 2024
@sumimakito @locao
fix(plugins): consistent error responses upon Admin API auth failures (…
04200bd 
…#12429)

* fix(plugins): consistent error responses upon Admin API auth failures

* fix(basic-auth): update error message

(cherry picked from commit 60ea714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

@nekolab nekolab nekolab approved these changes

@bungle bungle bungle approved these changes

Assignees

@sumimakito sumimakito

Labels
plugins/basic-auth plugins/key-auth plugins/ldap-auth size/M
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sumimakito @team-gateway-bot @bungle @nekolab @raoxiaoyan @AndyZhang0707