Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(router/atc): simplify the code of atc fields #12417

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jan 25, 2024

Summary

KAG-3634

  • alignment clean
  • remove check of http prefix in visit_for_context()

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as ready for review January 25, 2024 07:03
@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 29, 2024
@chronolaw chronolaw marked this pull request as draft January 30, 2024 04:12
@chronolaw chronolaw force-pushed the refactor/simplify_atc_fields branch from 8388b06 to 28a5347 Compare January 30, 2024 09:29
@chronolaw chronolaw marked this pull request as ready for review January 30, 2024 09:34
@chronolaw chronolaw force-pushed the refactor/simplify_atc_fields branch from 28a5347 to 6a85e8b Compare February 26, 2024 02:25
@kikito kikito merged commit 11f6b56 into master Feb 27, 2024
28 checks passed
@kikito kikito deleted the refactor/simplify_atc_fields branch February 27, 2024 09:10
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants