Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router/atc): support field http.path.segments.len #12398

Merged
merged 6 commits into from
Jan 24, 2024
Merged

feat(router/atc): support field http.path.segments.len #12398

merged 6 commits into from
Jan 24, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jan 23, 2024 •
edited by jira bot
Loading

Summary

KAG-3604

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 23, 2024
dndx
dndx requested changes Jan 23, 2024
View reviewed changes
kong/router/fields.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw added this to the 3.6.0 milestone Jan 23, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 23, 2024
@chronolaw chronolaw marked this pull request as ready for review January 23, 2024 09:37
@chobits chobits self-requested a review January 24, 2024 02:43
@AndyZhang0707 AndyZhang0707 requested a review from ADD-SP January 24, 2024 02:56
@dndx dndx force-pushed the feat/add_http_path_segments_len branch from ef224b3 to 916efc6 Compare January 24, 2024 06:13
@chronolaw chronolaw force-pushed the feat/add_http_path_segments_len branch from 916efc6 to 3d715fa Compare January 24, 2024 06:17
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 24, 2024
@dndx dndx merged commit 7353dc9 into master Jan 24, 2024
31 checks passed
@dndx dndx deleted the feat/add_http_path_segments_len branch January 24, 2024 07:06
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@chronolaw chronolaw mentioned this pull request Jan 24, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Jan 24, 2024
@chronolaw
feat(router/atc): add new field http.path.segments.len (#12398)
520fb31 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
chronolaw added a commit that referenced this pull request Jan 24, 2024
@chronolaw
feat(router/atc): add new field http.path.segments.len (#12398)
d758cbf 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
feat(router/atc): add new field http.path.segments.len (#12398)
e65ce18 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
feat(router/atc): add new field http.path.segments.len (#12398)
8ae1e34 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
chronolaw added a commit that referenced this pull request Mar 4, 2024
@chronolaw
feat(router/atc): add new field http.path.segments.len (#12398)
6c7bcf3 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
locao pushed a commit that referenced this pull request Mar 5, 2024
@chronolaw @locao
feat(router/atc): add new field http.path.segments.len (#12398)
ed04e58 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
feat(router/atc): add new field http.path.segments.len (#12398)
bfae925 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
feat(router/atc): add new field http.path.segments.len (#12398)
76ea926 
This field represents how much segments the request path contains.

For example, "/a/b/c/" contains 3 segments, "/a" contains 1 and "/" contains 0 segment.

It is useful for implementing segment based routing logic such as these used in OpenAPI spec.

KAG-3604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@dndx dndx dndx approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/router schema-change-noteworthy size/L skip-changelog
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chronolaw @team-gateway-bot @chobits @dndx @ADD-SP @kikito