-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdk): get the first http header value after bumping to OpenResty 1.25.3.1 #12370
Conversation
@chronolaw we need to somehow also handle the header modification case too? This is how our current code works I think: kong.service.request.set_header("a", "b")
local a = kong.request.get_header("a")
kong.service.request.set_header("a", "c")
local a2 = kong.request.get_header("a")
assert(a ~= a2) It would though be possible with this new ctx thing to have client request headers separated from upstream request headers, but that is not what we currently do, but something to think about perhaps, we already have:
That do separate service response headers from kong response headers (kong response headers sure contain the upstream response headers too, but they may contain modifications/additions too). Perhaps the cache thing needs to be in those global patches. |
If we have an assumption that multiple header value is not a frequent case when accessing by |
926b4f6
to
0d58604
Compare
a539a7e
to
b5f9bca
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12370-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12370-to-master-to-upstream
git checkout -b cherry-pick-12370-to-master-to-upstream
ancref=$(git merge-base 58fe2dd31c06a1f2910c2b69deb678f39c573177 1198c8132c4009849eeaec9bdbf134f13eab767b)
git cherry-pick -x $ancref..1198c8132c4009849eeaec9bdbf134f13eab767b |
Only when the cherry-pick of #12327 is merged we will cherry pick this one. |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12370-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12370-to-master-to-upstream
git checkout -b cherry-pick-12370-to-master-to-upstream
ancref=$(git merge-base 58fe2dd31c06a1f2910c2b69deb678f39c573177 1198c8132c4009849eeaec9bdbf134f13eab767b)
git cherry-pick -x $ancref..1198c8132c4009849eeaec9bdbf134f13eab767b |
Summary
It is a fixing PR for #12327.
KAG-3570
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]