chore(globalpatches): moved require kong.constants to the closure
#12328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because EE has changed `package.path` in this closure,
and we continue leave that at the top level of this file, EE's e2e
test will report the following error:
```
stack traceback:
/usr/local/share/lua/5.1/kong/constants.lua:8: in main chunk
[C]: in function 'require'
/usr/local/share/lua/5.1/kong/globalpatches.lua:8: in main chunk
[C]: in function 'require'
/usr/local/bin/kong:6: in function 'file_gen'
init_worker_by_lua(nginx.conf:118):46: in function <init_worker_by_lua(nginx.conf:118):44>
[C]: in function 'xpcall'
init_worker_by_lua(nginx.conf:118):53: in function <init_worker_by_lua(nginx.conf:118):51>
```
chronolaw
approved these changes
Jan 10, 2024
windmgc
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is necessary because EE has changed
package.pathin this closure, and if we continue leave that in the top-level scope of this file, EE's e2e test will report the following error:Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md