feat(clustering): CP/DP RPC framework & dynamic log level RPC #12320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
core/proxy
core/db/migrations
core/db
schema-change-noteworthy
labels
fffonion
reviewed
Jan 17, 2024
github-actions
bot
added
the
cherry-pick kong-ee
dndx
force-pushed
the
feat/cp_dp_rpc
branch
3 times, most recently
from
af8113e to
35426dd
Compare
chronolaw
reviewed
Apr 8, 2024
chronolaw
reviewed
Apr 8, 2024
chronolaw
reviewed
Apr 9, 2024
chronolaw
reviewed
Apr 9, 2024
chronolaw
reviewed
Apr 9, 2024
WebSocket client/server
`cjson` and let library throw an error
|
After discussion internally we have decided to address some of the styling reviews in a separate PR in order to keep the conversation manageable. The PR should be in a mergable state as long as it does not contain DoA type bugs that affects other components. |
nowNick
approved these changes
Apr 24, 2024
|
|
||
| while not exiting() do | ||
| repeat | ||
| local n, err = notifications_queue:pop(0) |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12320-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12320-to-master-to-upstream
git checkout -b cherry-pick-12320-to-master-to-upstream
ancref=$(git merge-base 9db89af20ac5b594b26e3a794fdb87e34db0a246 21b34f6c0aa8ce4c44eb0243667d2c5d29240481)
git cherry-pick -x $ancref..21b34f6c0aa8ce4c44eb0243667d2c5d29240481 |
github-actions
bot
added
the
incomplete-cherry-pick
locao
removed
the
incomplete-cherry-pick
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
This PR implements an extensible mechanism where CP and DP nodes can bidirectionally communicate with each other and perform RPC calls. Which can be used for building complex interactions such as config sync, debugging, etc. This PR also implements a simple RPC service for CP to inspect and change the dynamic log level of the connected DP nodes. The functionality is exposed via a new Admin API endpoint `/clustering/data-planes/<node-id>/log-level`. KAG-623 KAG-3751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a generic and extensible RPC framework that can be used to implement complex CP/DP interactions. This PR also implements a simple RPC "kong.debug.log_level.v1" that supports dynamic log level over RPC.
JSON RPC library
RPC framework
Compressions support
Authentication and encryption
Inert switch
Set log level over RPC
Get log level over RPC
Clear log level over RPC
[KAG-623]
KAG-3751
[KAG-623]: https://konghq.atlassian.net/browse/KAG-623?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ