Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prometheus): fix the description of some metrics #12293

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

johnfitzpatrick
Copy link
Contributor

I believe a number of Prometheus plugin configs are described incorrectly.

Summary

The description for status_code_metrics, latency_metrics, bandwidth_metrics, and upstream_health_metrics

"A boolean value that determines if status code metrics should be collected"

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Fix the description for status_code_metrics, latency_metrics, bandwidth_metrics,
and upstream_health_metrics.

Status code is mentioned instead of their correct names.
@gruceo gruceo force-pushed the johnfitzpatrick-patch-1 branch from b2a904a to fdd1be9 Compare March 6, 2024 14:05
@gruceo gruceo changed the title Update schema.lua docs(prometheus): fix the description of some metrics Mar 6, 2024
@locao locao merged commit 3fe3434 into master Mar 6, 2024
28 checks passed
@locao locao deleted the johnfitzpatrick-patch-1 branch March 6, 2024 14:25
@locao locao added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 1, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants